<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 17, 2014 at 5:19 AM, Lukas Fleischer <span dir="ltr"><<a href="mailto:cgit@cryptocrack.de" target="_blank">cgit@cryptocrack.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Use Git's built-in ident line splitting algorithm instead of<br>
reimplementing it. This does not only simplify the code but also makes<br>
sure that cgit is consistent with Git when it comes to author parsing.<br></blockquote><div><br></div><div>Thank heavens!</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+               email_len = ident.mail_end - ident.mail_begin;<br>
+               *email = xmalloc(strlen("<") + email_len + strlen(">\0"));<br>
+               sprintf(*email, "<%.*s>", email_len, ident.mail_begin);<br>
+<br></blockquote><div><br></div><div>strlen(">\0") -- isn't the null superfluous? Cleanup and resubmit?</div></div>
</div></div>