[pass] [PATCH] Allow options in EDITOR variable

[Allan Odgaard]

I see that my patch is reverting 
http://git.zx2c4.com/password-store/commit/?id=311c98c9140205f32be2720db9261c67da658c4c

Tools normally allow EDITOR to include options, so ‘pass’ does not 
follow the de facto standard. If it sets EDITOR when running tests, and 
the tests must be able to run from a path with spaces, I suggest 
creating a symlink e.g. from /tmp and set EDITOR to point to that 
symlink.

On 12 Jun 2014, at 11:16, Allan Odgaard wrote:

> This is required by most graphical editors, as the shell command they 
> provide needs to be told to wait until the file has been closed.
> ---
> src/password-store.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git src/password-store.sh src/password-store.sh
> index e68384b..8c6c9c5 100755
> --- src/password-store.sh
> +++ src/password-store.sh
> @@ -425,7 +425,7 @@ cmd_edit() {
> 		$GPG -d -o "$tmp_file" "${GPG_OPTS[@]}" "$passfile" || exit 1
> 		action="Edit"
> 	fi
> -	"${EDITOR:-vi}" "$tmp_file"
> +	${EDITOR:-vi} "$tmp_file"
> 	while ! $GPG -e "${GPG_RECIPIENT_ARGS[@]}" -o "$passfile" 
> "${GPG_OPTS[@]}" "$tmp_file"; do
> 		echo "GPG encryption failed. Retrying."
> 		sleep 1
> -- 
> 2.0.0
> _______________________________________________
> Password-Store mailing list
> Password-Store at lists.zx2c4.com
> http://lists.zx2c4.com/mailman/listinfo/password-store