<div dir="ltr"><div class="gmail_extra"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 17, 2014 at 10:45 AM, Jason A. Donenfeld <span dir="ltr"><<a href="mailto:Jason@zx2c4.com" target="_blank">Jason@zx2c4.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><p dir="ltr"><br>
On Apr 17, 2014 4:31 PM, "Brandon Jones" <<a href="mailto:jones.brandon.lee@gmail.com" target="_blank">jones.brandon.lee@gmail.com</a>> wrote:<br>
><br>
> Hi Jason,</p>
</div><p dir="ltr">Please remember to keep the list CCd.</p></blockquote><div>I was not aware you included a list. I'll be sure to hit reply-all now. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>
<p dir="ltr">><br>
> Manually changing the function worked, so that's all good.</p>
</div><p dir="ltr">Do NOT manually change the function. Do not modify /usr/bin/pass or src/password-store.sh. Instead ONLY modify src/platform/cygwin.sh. This is the location of the functions for cygwin. If you make adjustments to it, send a diff to the mailing list. This way, everyone benefits. Let me know if any part of that isn't clear.</p>
</blockquote><div> </div><div>The only thing that was unclear is the part where you say "verify this works, as well as the makefile." The statement implies that one should verify that the function works but not by any specific method. My apologies for choosing to do this by modifying the function within the /usr/bin/pass rather than modifying src/platform/cygwin.sh to call the function clip with two dummy variables. It didn't occur to me that it would matter either way. I've not been involved in any programming projects with others nor do I primarily use git or bash (for scripting I use python) so you'll have to take that into account. <br>
</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>
<p dir="ltr">> However I do get an error on "make install"<br>
><br>
> make install<br>
> removed `/usr/bin/pass'<br>
> `src/password-store.sh' -> `/usr/bin/pass'<br>
> removed `/usr/share/man/man1/pass.1'<br>
> `man/pass.1' -> `/usr/share/man/man1/pass.1'<br>
> removed `/usr/share/bash-completion/completions/pass'<br>
> `src/completion/pass.bash-completion' -> `/usr/share/bash-completion/completions/pass'<br>
> `src/platform/cygwin.sh' -> `/usr/lib/<a href="http://password-store.platform.sh" target="_blank">password-store.platform.sh</a>'<br>
> sed -i "" 's:.*platform-defined-functions.*:source /usr/lib/<a href="http://password-store.platform.sh" target="_blank">password-store.platform.sh</a>:' "/usr/bin/pass"<br>
> sed: can't read s:.*platform-defined-functions.*:source /usr/lib/<a href="http://password-store.platform.sh" target="_blank">password-store.platform.sh</a>:: No such file or directory<br>
> Makefile:28: recipe for target 'install' failed<br>
> make: *** [install] Error 2</p>
</div><p dir="ltr">I've fixed this now; thanks for reporting it. Git pull and try again...</p></blockquote><div><br></div><div>Getting git-pull to work in Cygwin is/can be a pain. I manually downloaded the zip file. It still did not work.</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> $make install<br>`src/password-store.sh' -> `/usr/bin/pass'<br>
`man/pass.1' -> `/usr/share/man/man1/pass.1'<br>removed `/usr/share/bash-completion/completions/pass'<br>`src/completion/pass.bash-completion' -> `/usr/share/bash-completion/completions/pass'<br>
`src/platform/cygwin.sh' -> `/usr/lib/<a href="http://password-store.platform.sh/" target="_blank">password-store.platform.sh</a>'<br>sed -i "" 's:.*platform-defined-functions.*:source /usr/lib/<a href="http://password-store.platform.sh/" target="_blank">password-store.platform.sh</a>:' "/usr/bin/pass"<br>
sed: can't read s:.*platform-defined-functions.*:source /usr/lib/<a href="http://password-store.platform.sh/" target="_blank">password-store.platform.sh</a>:: No such file or directory<br>Makefile:28: recipe for target 'install' failed<br>
make: *** [install] Error 2</blockquote><div class="gmail_extra"><div><br></div><div><br></div><div>For what it's worth, the file does exist:</div><div><br></div><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
04/17/14 11:38 AM #####@##### ~/password-store<br>$make uninstall<br>removed `/usr/bin/pass'<br>removed `/usr/share/man/man1/pass.1'<br>removed `/usr/lib/<a href="http://password-store.platform.sh">password-store.platform.sh</a>'<br>
</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> </blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
04/17/14 11:39 AM #####@##### ~/password-store<br>$make install<br>`src/password-store.sh' -> `/usr/bin/pass'<br>`man/pass.1' -> `/usr/share/man/man1/pass.1'<br>removed `/usr/share/bash-completion/completions/pass'<br>
`src/completion/pass.bash-completion' -> `/usr/share/bash-completion/completions/pass'<br>`src/platform/cygwin.sh' -> `/usr/lib/<a href="http://password-store.platform.sh">password-store.platform.sh</a>'<br>
sed -i "" 's:.*platform-defined-functions.*:source /usr/lib/<a href="http://password-store.platform.sh">password-store.platform.sh</a>:' "/usr/bin/pass"<br>sed: can't read s:.*platform-defined-functions.*:source /usr/lib/<a href="http://password-store.platform.sh">password-store.platform.sh</a>:: No such file or directory<br>
Makefile:28: recipe for target 'install' failed<br>make: *** [install] Error 2<br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">04/17/14 11:39 AM #####@##### ~/password-store<br>
$ls -l /usr/lib/<a href="http://password-store.platform.sh">password-store.platform.sh</a><br>-rw-r--r-- 1 ##### Domain Users 668 Apr 17 11:39 /usr/lib/<a href="http://password-store.platform.sh">password-store.platform.sh</a></blockquote>
<div><br></div></div></div></div><br></div></div>