<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div style="font-family:Arial;">On Tue, Oct 8, 2019, at 17:32, Devin Smith wrote:<br></div><blockquote type="cite" id="qt"><div>- grouping = DEFAULT_GROUP if grouping == nil<br></div><div>+ grouping = DEFAULT_GROUP if grouping.empty?<br></div></blockquote><div><br></div><blockquote type="cite" id="qt"><div style="font-family:Arial;">Although - it looks like this line was intentionally changed <a href="https://git.zx2c4.com/password-store/commit/contrib/importers/lastpass2pass.rb?id=85757e99bff29d6fa663a6b291c9047ccce8c6d3">https://git.zx2c4.com/password-store/commit/contrib/importers/lastpass2pass.rb?id=85757e99bff29d6fa663a6b291c9047ccce8c6d3</a>.<br></div><div><br></div><div>I'm not familiar with ruby, but here is my version:<br></div></blockquote><div style="font-family:Arial;"><br></div><div style="font-family:Arial;">To cover both the nil and empty string cases, one might check for `grouping.to_s.empty?`.<br></div><div style="font-family:Arial;"><br></div></body></html>