cgit pull request: diffs in atom feed

[Lars Hjemli]

On Sat, Mar 26, 2011 at 16:31, Andreas Zwinkau <beza1e1 at web.de> wrote:
> On Sat, Mar 26, 2011 at 4:00 PM, Lars Hjemli <hjemli at gmail.com> wrote:
>> On Mon, Mar 7, 2011 at 10:54, Andreas Zwinkau <beza1e1 at web.de> wrote:
>>> i wanted the see the diffs in the cgit atom feeds. You can find my
>>> changes at https://github.com/beza1e1/cgit
>>> This also adds a test script (tests/t0109-atom.sh) for the feed page.
>>
>> How does the diffstat (and the diffs themselves, especially if
>> side-by-side diffs are default) appear when there's no css involved?
>> Maybe cgit_print_patch() would work better than cgit_print_diff() in
>> atom feeds?
>
> You can see my fork in action here:
>  http://pp.info.uni-karlsruhe.de/cgi-bin/cgit.cgi/

I've tried looking at the modified feed with firefox, opera, and
google reader, and it's basically unreadable.


> Personally, i like the fact that i can apply user-styles to my feeds
> and print_diff provides the necessary markup. This is where it ends
> up:
>  http://pp.info.uni-karlsruhe.de/~zwinkau/feeds/#item-6fecb410

For such a specialized client it might make sense, but I think the
atom feeds should be readable by _any_ client.

--
larsh