Pull request: Use userdiff configuration

Lars Hjemli hjemli at gmail.com
Thu Apr 7 12:30:46 CEST 2011

On Tue, Apr 5, 2011 at 13:38, Jonathon Mah <me at jonathonmah.com> wrote:
> I have to explicitly tell git to use the objc diff header, through gitattributes:
> *.m diff=objc
> (the patterns for which are built in to git, in userdiff.c).
> For non-built-in diff types, you can also specify a "textconv" filter, through which
> both versions are piped before diffing. I spent some time today making one that
> has nice output for Cocoa's serialized interface files (.xib).
> So I have some patches to cgit to respect both the userdiff xfuncname and
> textconv. I made them relative to v0.9, and have rebased it onto master. The branch
> is here: <https://github.com/jmah/cgit/commits/userdiff>

Thanks. The changes looks good, but I'm a bit concerned about textconv
security. Maybe this feature should be disabled by default?


More information about the CGit mailing list