[PATCH] initialize buf2 properly

Julius Plenz plenz at cis.fu-berlin.de
Thu Apr 7 12:58:01 CEST 2011


* Lars Hjemli <hjemli at gmail.com> [2011-04-07 12:54]:
> On Wed, Apr 6, 2011 at 13:55, Julius Plenz <plenz at cis.fu-berlin.de> wrote:
> > I don't see why you would want buf2 to be static in nature.
> 
> To keep the 64 bytes off the stack, but it's not a big deal.

Not at all. Also, it may just lead to weird results.

> I think we should just properly check the result from parse_date():

That's an option too. Maybe you'll just initialize it with zeros *and*
check the return value? :-)

Julius




More information about the CGit mailing list