[PATCH] guess default branch from HEAD

chris jugg at hotmail.com
Tue Jul 19 12:13:54 CEST 2011


 <larsh at ...> writes:
> On Tue, Jul 19, 2011 at 09:35:42AM +0000, chris wrote:
> > Should guess_defbranch() be called here instead of hard-coding "master"?
> 
> I don't think so, due to performance concerns (as explained earlier in this
> thread). It's a compromise, favoring performance over correctness.

Well, it sounds like premature optimization to me.  I wonder how much 
performance impact that would really have, and if cgit's caching support doesn't 
negate any potential issue on busy servers anyway.

I would expect correctness in user experience first.  If correctness is shown to 
impact performance, I would expect solutions/compromises in those specific cases 
as needed.

Of course I'm free to patch it to my liking obviously.  This is just some user 
feedback for you.

Thanks!

chris





More information about the CGit mailing list