paging and sorting in the repository overview

larsh at larsh at
Thu Jul 21 12:30:50 CEST 2011

On Wed, Jul 20, 2011 at 01:57:01PM +0200, Thomas Moschny wrote:
> we are displaying a whole bunch (>50) of repositories via cgit, and
> there's a small issue with the overview page: it seems paging is done
> before sorting. Or, more precisely, repositories are first sorted
> alphabetically, then paging is done, and finally the requested sort
> order (for example according to their idle time via ?s=idle) is applied
> to the page. I'd instead expect sorting to be done before paging.

Yeah, this looks like a bug - cgit_index_link(), used by print_pager()
in ui-repolist.c, doesn't honor the sort option. I'll push a fix
tonight (currently at $DAYJOB).


More information about the CGit mailing list