Interposing administrator defined javascript in cgit....

Convey, Simon sconvey at idirect.net
Wed Jun 29 20:41:42 CEST 2011


Dear cgit devteam,
         We are moving a large CVS rpository to git. ( We did a long mercurial vs git eval, and git won hands down ). CVS  has a web based code brower, and whilst its nowhere near as pretty as cgit,, it has one feature which cgit lacks, and that's an arbitrary file diff.  We implemented this this using javascript, and we've realised that being able to interpose javascript in cgit is a really useful feature. I have added code to cgit to do this, and some example javascript which does useful things.  I tried a git push earlier, but its not accepting pushes. Do you need my IP address ? 206.205.108.*

Here's the added code.....

cgit.c   Added an extra config options to void config_cb(const char *name,const char *value)

          
                else if (!strcmp(name, "javascript"))
                        ctx.cfg.javascript = xstrdup(value);

          
cgit.h    Added the typedef to struct cgit_config
           
                        char *javascript;

ui-shared.c   Added a call to html_include as soon as <body> is sent.
             
                   if (ctx-cfg.header)
                           html_include(ctx->cfg.header);
                   html_include(ctx-cfg.javascript);

And added a README.js, and example code to a contrib directory, updated cgitrc.5.txt with an example stanza.

If these changes are OK, please you you allow us to push them ?

Many thanks,
Simon Convey
Ahmed Elsabbahy






</PRE><BR><span style='font-size:8.0pt;font-family:"Arial","sans-serif";color:#003366'>
_____________________________________________________<BR> 
This electronic message and any files transmitted with it contains<BR>
information from iDirect, which may be privileged, proprietary<BR>
and/or confidential. It is intended solely for the use of the individual<BR>
or entity to whom they are addressed. If you are not the original<BR>
recipient or the person responsible for delivering the email to the<BR> intended recipient, be advised that you have received this email<BR>
in error, and that any use, dissemination, forwarding, printing, or<BR> copying of this email is strictly prohibited. If you received this email<BR>
in error, please delete it and immediately notify the sender.<BR>
_____________________________________________________ 
</SPAN><PRE>


More information about the CGit mailing list