[PATCH 4/5] fix two encoding bugs

Lars Hjemli hjemli at gmail.com
Thu Mar 10 18:29:49 CET 2011

On Thu, Mar 10, 2011 at 17:03, Julius Plenz <plenz at cis.fu-berlin.de> wrote:
> reencode() takes three arguments in the order (txt, from, to), opposed to
> reencode_string, which will, like iconv, handle the arguments with from
> and to swapped. Fix that (this makes reencode more intuitive).

Oh my. Thanks for fixing this.

> If src and dst encoding are equivalent, don't do any encoding.
> If no special encoding parameter is found within the commit, assume
> UTF-8 and explicitly convert to PAGE_ENCODING. The change to reencode()
> mentioned above avoids re-encoding a UTF-8 string to UTF-8, for example.

These two changes also makes sense. Will apply.


More information about the CGit mailing list