[cgit] [PATCH] Fix crash when projectsfile cannot be opened

[Lars Hjemli]

[added cgit list to CC]

On Sat, Mar 26, 2011 at 09:51, Stefan Gehn <stefan at srcbox.net> wrote:
> here's a trivial patch that makes cgit properly abort in case the
> projectsfile cannot be opened. Without the added return cgit continues
> using the projects pointer which is NULL and thus causes a segfault.

Thanks, I've applied your patch as attached to the stable branch on
hjemli.net/git/cgit, so it will be included in cgit-0.9.0.1 in the not
to distant future.

>From f15c5833d2190bc62e0e1e3e9753ef33230ecd53 Mon Sep 17 00:00:00 2001
From: Stefan Gehn <stefan at srcbox.net>
Date: Sat, 26 Mar 2011 09:51:39 +0100
Subject: [PATCH] Fix crash when projectsfile cannot be opened

This patch makes cgit properly abort in case the projectsfile cannot
be opened. Without the added return cgit continues using the projects
pointer which is NULL and thus causes a segfault.

diff --git a/scan-tree.c b/scan-tree.c
index 627af1b..e5a4baf 100644
--- a/scan-tree.c
+++ b/scan-tree.c
@@ -219,6 +219,7 @@ void scan_projects(const char *path, const char
*projectsfile, repo_config_fn fn
 	if (!projects) {
 		fprintf(stderr, "Error opening projectsfile %s: %s (%d)\n",
 			projectsfile, strerror(errno), errno);
+		return;
 	}
 	while (fgets(line, sizeof(line), projects) != NULL) {
 		for (z = &lastc(line);
-- 
1.7.2.3