Build Errors with Git 1.7.2.5

[P. J. McDermott]

Hi,

I'm trying to build and install cgit on my Debian GNU/Linux 6.0.2.1
server, but I'm getting some compiler warnings and linker errors.  I
pulled cgit from the repository today (head: 756e3ea6), and this is what
I've done:
  ~$ git clone git://hjemli.net/pub/git/cgit
  ~$ cd cgit/
  ~/cgit$ git submodule init
  ~/cgit$ $EDITOR .git/config
  (set "url" under submodule "git" to "https://github.com/git/git.git"
  since git.kernel.org is still down)
  ~/cgit$ git submodule update
  ~/cgit$ cd git/
  ~/cgit/git$ git checkout v1.7.2.5
  ~/cgit/git$ cd ../
  ~/cgit$ $EDITOR cgit.conf
  (see below)
  ~/cgit$ make
  ...
  ui-log.c: In function ‘print_commit’:
  ui-log.c:109: warning: implicit declaration of function
  ‘graph_next_line’
  ui-log.c: In function ‘cgit_print_log’:
  ui-log.c:323: warning: implicit declaration of function
  ‘graph_set_column_colors’
  ...
  ui-log.o: In function `print_commit':
  /home/pj/cgit/ui-log.c:109: undefined reference to `graph_next_line'
  /home/pj/cgit/ui-log.c:222: undefined reference to `graph_next_line'
  ui-log.o: In function `cgit_print_log':
  /home/pj/cgit/ui-log.c:323: undefined reference to
  `graph_set_column_colors'
  collect2: ld returned 1 exit status
  make: *** [cgit] Error 1

This is my 'cgit.conf':
  CGIT_SCRIPT_PATH = /var/www/cgit
  prefix = /usr/local
  GIT_VER = 1.7.2.5

I checked out version 1.7.2.5 of Git and set GIT_VER accordingly because
that is the version installed on my system.

I see that the declaration of 'graph_next_line()' was moved from
'graph.c' to 'graph.h' in Git in commit 6bdc17d9 last July, though for
whatever reason the change didn't get included in Git 1.7.2.5.
Similarly, 'graph_set_custom_colors()' was added to Git in commit
1e3d4119 last July.  Should I just apply those two commits to my Git
1.7.2.5 tree to build cgit?  Or is it safe to build cgit against a
version of Git different from the one installed?

Please CC me on replies.

Thanks!

-- 
P. J. McDermott
mailto:pjm at nac.net | http://identi.ca/pehjota