[PATCH 1/2] correct length check for LCS table
Jamie Couture
jamie.couture at gmail.com
Thu Jan 12 04:38:48 CET 2012
From: Eric Wong <normalperson at yhbt.net>
Each individual string may be too long for its respective
dimension of the LCS table.
Signed-off-by: Eric Wong <normalperson at yhbt.net>
Signed-off-by: Jamie Couture <jamie.couture at gmail.com>
---
ui-ssdiff.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/ui-ssdiff.c b/ui-ssdiff.c
index 9fb5b11..45770b1 100644
--- a/ui-ssdiff.c
+++ b/ui-ssdiff.c
@@ -42,14 +42,12 @@ static char *longest_common_subsequence(char *A, char *B)
int i, j, ri;
int m = strlen(A);
int n = strlen(B);
- int tmp1, tmp2, length;
+ int tmp1, tmp2;
int lcs_length;
char *result;
- length = (m + 1) * (n + 1);
-
// We bail if the lines are too long
- if (length > MAX_SSDIFF_SIZE)
+ if (m >= MAX_SSDIFF_M || n >= MAX_SSDIFF_N)
return NULL;
create_or_reset_lcs_table();
--
1.7.7.4
More information about the CGit
mailing list