[PATCH] add TITLE to log commit entries

Lars Hjemli hjemli at gmail.com
Sun Mar 18 10:55:17 CET 2012


On Fri, Mar 2, 2012 at 23:08, Josef wells <Josefwells at alumni.utexas.net> wrote:
> ---
>  ui-shared.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/ui-shared.c b/ui-shared.c
> index 3e9282f..305342d 100644
> --- a/ui-shared.c
> +++ b/ui-shared.c
> @@ -360,7 +360,12 @@ void cgit_commit_link(char *name, const char
> *title, const char *class,
>                html("ignorews=1");
>                delim = "&";
>        }
> -       html("'>");
> +       html("' ");
> +       if (rev && strcmp(rev, ctx.qry.head)) {
> +               html("TITLE=");
> +               html_url_arg(rev);
> +       }
> +       html(">");
>        html_txt(name);
>        html("</a>");
>  }

The title-attribute is already set (in repolink()) from the title
argument, i.e. the caller of cgit_commit_link() decides what title, if
any, should be set on the link.

But fwiw, I don't think showing the commit sha1 as link title is very useful.

--
larsh




More information about the CGit mailing list