[PATCH v1 RESEND 2/3] css: vertically align the cgit logo image

larsh at hjemli.net larsh at hjemli.net
Sun Mar 18 12:28:12 CET 2012


On Sun, Mar 18, 2012 at 11:58:33AM +0100, Ferry Huberts wrote:
> 
> 
> On 18-03-12 12:03, larsh at hjemli.net wrote:
> >On Sun, Mar 18, 2012 at 11:44:04AM +0100, Ferry Huberts wrote:
> >>From: Ferry Huberts<ferry.huberts at pelagic.nl>
> >>
> >>Signed-off-by: Ferry Huberts<ferry.huberts at pelagic.nl>
> >>---
> >>  cgit.css |    1 +
> >>  1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >>diff --git a/cgit.css b/cgit.css
> >>index 4b79c1c..51b04fe 100644
> >>--- a/cgit.css
> >>+++ b/cgit.css
> >>@@ -31,6 +31,7 @@ div#cgit table#header {
> >>
> >>  div#cgit table#header td.logo {
> >>  	width: 96px;
> >>+	vertical-align: top;
> >>  }
> >Why is this needed?
> 
> I have written a trac plugin that embeds cgit,

Cool.

> and the logo is placement 
> is completely off when not doing this

Ok. I don't mind specifying a value for vertical-align, I just needed a
rationale. Will apply with amended commit message.

--
larsh




More information about the CGit mailing list