[PATCH] add git config parsing during scan-path

Jason A. Donenfeld Jason at zx2c4.com
Tue Oct 9 13:33:15 CEST 2012

On Tue, Oct 9, 2012 at 12:56 PM, Jamie Couture <jamie.couture at gmail.com> wrote:
> +       else if (!prefixcmp(key, "cgit.")) {
> +               config_fn(repo, key + 5, value);
> +       }
> +

This check isn't sufficient, since if the enable_git_config is not
enabled, but the existing gitweb_section/description settings are
enabled, then enable_git_config becomes implicitly enabled.

But maybe this points to a larger issue: too many settings here. It
seems like we might be best with a single enable_git_config setting
that takes into account known gitweb.* as well as merging cgit.*.

OTOH, maybe it's better to just add a defbranch key to the gitweb
namespace. There already exists category, owner, and description. If
we add defbranch, what other features are folks actually going to want
to be configurable within gitconfig?

If there are additional keys that people want, then I'm fine having
the gitweb namespace as well as the cgit namespace, but if this is
actually just in the name of defbranch, there might be a simpler

More information about the CGit mailing list