[PATCH 1/3] Added "sort-sections" flag for the repository listing

Tobias Bieniek Tobias.Bieniek at gmx.de
Tue Oct 9 23:47:04 CEST 2012


>> This makes it possible to activate the enable_commit_graph,
>> enable_log_filecount and enable_log_linecount for individual
>> repositories, even if the global setting is "0" (default).
>>
>>
>> - repo->enable_commit_graph = ctx.cfg.enable_commit_graph * atoi(value);
>> + repo->enable_commit_graph = atoi(value);
>
> Was this the intended behavior before, or was this erroneously copy
> and pasted from elsewhere, and is therefore a bug? What I'm wondering
> is -- should I evaluate this as a behavior change or as a bug fix?

IMHO this should be treated as a bug fix. The settings for the
individual repos should overwrite the global settings. If I remember
correctly this is the way most other settings are handled too only
these few settings were not doing it properly.




More information about the CGit mailing list