[PATCHv2 2/3] Add ability to authorize viewing a repository

Jason A. Donenfeld Jason at zx2c4.com
Sun Oct 28 02:33:08 CET 2012

On Sat, Oct 27, 2012 at 7:29 PM, Ben Boeckel <mathstuf at gmail.com> wrote:
> Well, that would require that we either shell-split the option (messy
> and error prone in and of itself) or effectively require trampoline
> scripts for everything due to enforced arguments. Though...something
> taking these arguments naturally is unlikely. +1 for fork/exec here.

In light of the prior suggestion of leaving the env var choice to the
helper script, a trampoline is gonna be necessary no matter what. For
resource intensive things, just write it in C.

On the topic of 'enforced arguments', it might be cleaner to actually
pass everything we need as environment variables (set within the fork
before the exec). That way scripts don't have to messily deal with
positional arguments.

More information about the CGit mailing list