[PATCH] tests: use Git's test framework
john at keeping.me.uk
Thu Apr 4 16:34:04 CEST 2013
On Thu, Apr 04, 2013 at 04:24:57PM +0200, Jason A. Donenfeld wrote:
> On Mon, Apr 1, 2013 at 4:09 PM, John Keeping <john at keeping.me.uk> wrote:
> > This allows tests to run in parallel as well as letting us use "prove"
> > or another TAP harness to run the tests.
> > Git's test framework requires Git to be fully built before letting any
> > tests run, so add a new target to the top-level Makefile which builds
> > all of Git instead of just libgit.a and make the "test" target depend on
> > that.
> I don't think that's a problem. Technically, the tests should be
> against the git revision that cgit uses, not the system git.
> My only hesitation is whether or not the pretty printing benefits are
> worth the added complexity.
Personally I think the big improvement here is the ability to run the
tests in parallel. I quite often run "make -j4 test" only to remember
that CGit's tests don't work when run in parallel.
The prettier output and ability to do things like
"prove --state=host,all,save" is just a bonus.
More information about the CGit