[PATCH 10/19] ui-refs.c: use struct strbuf instead of fixed-size buffers
John Keeping
john at keeping.me.uk
Sun Apr 7 11:30:01 CEST 2013
Signed-off-by: John Keeping <john at keeping.me.uk>
---
ui-refs.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/ui-refs.c b/ui-refs.c
index 5bebed1..399c157 100644
--- a/ui-refs.c
+++ b/ui-refs.c
@@ -102,7 +102,7 @@ static void print_tag_header()
static void print_tag_downloads(const struct cgit_repo *repo, const char *ref)
{
const struct cgit_snapshot_format* f;
- char *filename;
+ struct strbuf filename = STRBUF_INIT;
const char *basename;
int free_ref = 0;
@@ -114,7 +114,9 @@ static void print_tag_downloads(const struct cgit_repo *repo, const char *ref)
if ((ref[0] == 'v' || ref[0] == 'V') && isdigit(ref[1]))
ref++;
if (isdigit(ref[0])) {
- ref = xstrdup(fmt("%s-%s", basename, ref));
+ struct strbuf buf = STRBUF_INIT;
+ strbuf_addf(&buf, "%s-%s", basename, ref);
+ ref = strbuf_detach(&buf, NULL);
free_ref = 1;
}
}
@@ -122,13 +124,14 @@ static void print_tag_downloads(const struct cgit_repo *repo, const char *ref)
for (f = cgit_snapshot_formats; f->suffix; f++) {
if (!(repo->snapshots & f->bit))
continue;
- filename = fmt("%s%s", ref, f->suffix);
- cgit_snapshot_link(filename, NULL, NULL, NULL, NULL, filename);
+ strbuf_addf(&filename, "%s%s", ref, f->suffix);
+ cgit_snapshot_link(filename.buf, NULL, NULL, NULL, NULL, filename.buf);
html(" ");
}
if (free_ref)
free((char *)ref);
+ strbuf_release(&filename);
}
static int print_tag(struct refinfo *ref)
{
--
1.8.2.692.g17a9715
More information about the CGit
mailing list