[PATCH 19/19] ui-shared.c: use struct strbuf instead of fmt()

[Jason A. Donenfeld]

On Sun, Apr 7, 2013 at 11:30 AM, John Keeping <john at keeping.me.uk> wrote:
>  const char *cgit_hosturl()
>  {
> +       struct strbuf sb = STRBUF_INIT;
>         if (ctx.env.http_host)
>                 return ctx.env.http_host;
>         if (!ctx.env.server_name)
>                 return NULL;
>         if (!ctx.env.server_port || atoi(ctx.env.server_port) == 80)
>                 return ctx.env.server_name;
> -       return xstrdup(fmt("%s:%s", ctx.env.server_name, ctx.env.server_port));
> +       strbuf_addf(&sb, "%s:%s", ctx.env.server_name, ctx.env.server_port);
> +       return strbuf_detach(&sb, NULL);
>  }

Constness issues, since we're going to want to perhaps deallocate this
at some point?