[PATCH v2 22/22] ui-shared.c: use struct strbuf instead of fmt()

John Keeping john at keeping.me.uk
Mon Apr 8 19:40:54 CEST 2013


On Mon, Apr 08, 2013 at 04:04:49PM +0200, Jason A. Donenfeld wrote:
> On Mon, Apr 8, 2013 at 12:22 PM, Lukas Fleischer <cgit at cryptocrack.de> wrote:
> > On Sun, Apr 07, 2013 at 04:43:26PM +0100, John Keeping wrote:
> >> Thanks.  Fixed and pushed to my GitHub repository [1].  I'll avoid
> >> sending another reroll of the entire series and only send incremental
> >> patches here if nothing serious is found.
> >
> > Note that you added the patch history to some of the commit messages for
> > some reason...
> 
> I've got this fixed in the branch here --
> http://git.zx2c4.com/cgit/log/?h=jk/fixed-size-buffer
> 
> As well, this branch is now rebased against master, which recently
> received a considerable merge from wip.

Thanks.  I tend to use "git commit --squash=..." and list the changes in
the commit message, to be tidied while running git-format-patch.

I know notes are the correct way to do that, I just need to retrain
myself to use them. :-)




More information about the CGit mailing list