[PATCH] Update git to v1.8.2.1

[John Keeping]

On Mon, Apr 08, 2013 at 08:16:14PM +0200, Ferry Huberts wrote:
> 
> 
> On 08/04/13 20:12, Ferry Huberts wrote:
> > I'm sorry to report that this patch, commit
> > 849ecd961df9454d6f849eac34e6f501395c4f01, breaks on my CentOS 6.4 servers.
> > 
> > I'm getting an 'Internal Server Error' with entries like the following
> > in the logs, and cgit just dies.
> > 
> >> [Mon Apr 08 20:01:38 2013] [error] [client 192.168.180.8] warning: unable to access '/root/etc/gitconfig': Permission denied, referer: https://git/reposerf/cgit/
> >> [Mon Apr 08 20:01:38 2013] [error] [client 192.168.180.8] warning: unable to access '/root/etc/gitattributes': Permission denied, referer: https://git/reposerf/cgit/
> >>
> >> [Mon Apr 08 20:07:19 2013] [error] [client 192.168.180.8] fatal: unable to access '/root/etc/gitconfig': Permission denied, referer: http://git/reposerf/cgit/
> >> [Mon Apr 08 20:07:19 2013] [error] [client 192.168.180.8] Premature end of script headers: reposerfCgit.cgi, referer: http://git/reposerf/cgit/
> >>
> >> [Mon Apr 08 20:07:28 2013] [error] [client 192.168.180.8] fatal: unable to access '/root/etc/gitconfig': Permission denied, referer: http://git/reposerf/cgit/
> >> [Mon Apr 08 20:07:28 2013] [error] [client 192.168.180.8] Premature end of script headers: reposerfCgit.cgi, referer: http://git/reposerf/cgit/
> > 
> > 
> > 
> > Why are these files suddenly accessed?
> > They weren't before...
> 
> Correction, when reverting back to my previous cgit, I see that these
> files are accessed, but cgit works properly there.

I think this is a behaviour change in Git then.

Having looked a bit more, there are environment variables to suppress
these lookups.  I wonder if we should set them in CGit, or is that
likely to lose behaviour people want?