[PATCH] t0109: chain operations with &&

John Keeping john at keeping.me.uk
Wed Apr 10 14:11:57 CEST 2013


Without '&&' between operations, we will not detect if strace or cgit
exit with an error status, which would cause a false positive test
status in this case.

Signed-off-by: John Keeping <john at keeping.me.uk>
---
 tests/t0109-gitconfig.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/t0109-gitconfig.sh b/tests/t0109-gitconfig.sh
index cdd570b..f64e691 100755
--- a/tests/t0109-gitconfig.sh
+++ b/tests/t0109-gitconfig.sh
@@ -18,7 +18,7 @@ test_expect_success 'no access to $HOME' '
 		-E HOME="$non_existant_path" \
 		-E CGIT_CONFIG="$PWD/cgitrc" \
 		-E QUERY_STRING="url=foo/commit" \
-		-e access -f -o strace.out cgit
+		-e access -f -o strace.out cgit &&
 	test_must_fail grep "$non_existant_path" strace.out
 '
 
-- 
1.8.2.694.ga76e9c3.dirty





More information about the CGit mailing list