[PATCH] configfile: Use git's internal config system instead.

Kyle J. McKay mackyle at gmail.com
Mon Aug 12 21:18:14 CEST 2013

On Aug 12, 2013, at 11:35, Jason A. Donenfeld wrote:
> On Tue, Jun 4, 2013 at 8:52 PM, Lukas Fleischer  
> <cgit at cryptocrack.de> wrote:
>> git_config_from_file() does not allow dots (".") inside configuration
>> variable names (since they are used to delimit sections from keys).  
>> If
>> we want to use the Git configuration system like this, we have to  
>> change
>> our configuration file format to use sections ("[repo]") instead of
>> prefixing each variable ("repo.").
> I had feared this would be the case. I still think it might be
> worthwhile to pursue revamping our configuration format to use
> git_config_from_file along with all its niceties. This would also put
> us somewhat more in line with upstream git and would allow all sorts
> of neat things -- for example instead of a per-repo cgitrc, a repo's
> bare gitconfig file could be used instead. We already support reading
> a few keys out of it, and moving to using git's config format for
> everything would allow us to unify all of this.

Also, starting with the 1.8.4 release (currently at 1.8.4-rc2), it's  
possible to do config_from_blob which may also make some of this easier.

More information about the CGit mailing list