[PATCH v2 2/4] ui-patch.c: Use log_tree_commit() to generate diffs

Lukas Fleischer cgit at cryptocrack.de
Fri Aug 16 23:46:00 CEST 2013

On Fri, Aug 16, 2013 at 01:16:12PM -0600, Jason A. Donenfeld wrote:
> On Thu, Aug 15, 2013 at 4:01 PM, Lukas Fleischer <cgit at cryptocrack.de> wrote:
>     -       if (!ctx.cfg.noplainemail) {
>     -               htmlf(" %s", info->author_email);
>     -       }
> Unfortunately this kills the noplainemail functionality:
>     noplainemail::
>             If set to "1" showing full author email addresses will be disabled.
>             Default value: "0".
> What to do here? 

Not sure, but note that we didn't do this properly anyway. Even with
noplainemail enabled, we did not hide any email addresses appearing in
the commit message -- and a lot of projects use sign-offs. The whole
option makes no sense if we mask the author email addresses but keep
"Signed-off-by:" lines.

To come back to your question, I think we could probably use pretty
formats to achieve that. Other possibilities would involve manipulating
each commit buffer before calling log_tree_commit() or patching Git to
have an internal option to hide e-mail addresses. Not very elegant :)


More information about the CGit mailing list