Return "404 Not found" if a repo doesn't exist (any more).

Adam Sjøgren asjo at koldfront.dk
Fri Feb 1 18:48:21 CET 2013


On Fri, 1 Feb 2013 12:58:25 +0100, Jason wrote:

> On Sat, Dec 1, 2012 at 11:02 PM, Adam Sjøgren <asjo at koldfront.dk> wrote:

>> @@ -247,6 +247,17 @@ void cgit_print_repolist()

>> +       for (i=0; i<cgit_repolist.count; i++) {
>> +               if (!(is_match(&cgit_repolist.repos[i]) && is_in_url(&cgit_repolist.repos[i])))
>> +                       continue;
>> +               hits++;
>> +        }

>> +       if (!hits) {
>> +                ctx.page.status = 404;

> I like the idea of this, but I hate to duplicate the loop logic like that.

Yeah, that is ugly.

> But in fact we do need to know whether there are any hits before
> sending headers.

That's how far I got...

> Tricky. I'll see if I can refactor things to be a bit nicer.

Sounds great!


  Best regards,

    Adam

-- 
 "Ge mig en vinterdrog, ge mig allt du har                    Adam Sjøgren
  Kom nu jag är kroniskt låg, bara mörkret hörs"         asjo at koldfront.dk





More information about the CGit mailing list