[PATCH] configfile: Use git's internal config system instead.

Lukas Fleischer cgit at cryptocrack.de
Tue Jun 4 20:52:02 CEST 2013


On Tue, Jun 04, 2013 at 07:58:48PM +0200, Jason A. Donenfeld wrote:
> This commit is completely broken and does not work but here's the
> general idea if someone would like to clean it up and work out the
> details.
> ---
>  cgit.c       | 12 +++++----
>  cgit.mk      |  1 -
>  configfile.c | 87 ------------------------------------------------------------
>  configfile.h |  8 ------
>  scan-tree.c  |  7 ++---
>  5 files changed, 11 insertions(+), 104 deletions(-)
>  delete mode 100644 configfile.c
>  delete mode 100644 configfile.h
> 
> [...]
> +		git_config_from_file(config_cb, expand_macros(value), NULL);

git_config_from_file() does not allow dots (".") inside configuration
variable names (since they are used to delimit sections from keys). If
we want to use the Git configuration system like this, we have to change
our configuration file format to use sections ("[repo]") instead of
prefixing each variable ("repo.").


More information about the CGit mailing list