CGit Log Links do not have the object id parameter

Lukas Fleischer cgit at cryptocrack.de
Mon Jun 17 21:07:45 CEST 2013


On Mon, Jun 17, 2013 at 12:01:49PM -0500, Jason wrote:
> The "id" parameter is not added to the "log" links.
> 
> For example if you open this commit view http://git.zx2c4.com/cgit/commit/?id=
> 52c926cadbff5fd0aaf00ebd79619112aba46182 and look at the log link from that
> page, you'll notice the id parameter is not retained.
> 
> From a quick glance at the source code it looks like the object id should be
> kept when generating log links.
> Is this a bug?

No, I think that this is intentional. We skip the revision parameter in
the cgit_log_link() invocation in cgit_print_pageheader().

The "log" links allows for getting back to the long list of current
commits with one click. I am not sure whether there are a lot of use
cases for getting a list of commits, starting from the one that is
currently selected.

> _______________________________________________
> CGit mailing list
> CGit at lists.zx2c4.com
> http://lists.zx2c4.com/mailman/listinfo/cgit



More information about the CGit mailing list