[PATCH 0/6] Update to a more recent Git

Jason A. Donenfeld Jason at zx2c4.com
Sat Mar 2 16:08:53 CET 2013

These patches are great. Thanks a lot for them -- I was going to do
this myself, not realizing others were already on the case. Great.
They're in the upstream-git branch for the moment during review.


On Sat, Mar 2, 2013 at 7:32 AM, John Keeping <john at keeping.me.uk> wrote:
> The changes here are reasonably straightforward, but v1.8.0 makes things
> a lot more difficult due to Git commit ba35480 (graph.c: mark private
> file-scope symbols as static, 2012-09-15).  I'll see if Junio can be
> persuaded to revert that before trying anything too horrible here -

I saw that a little bit earlier as well.

The reason evidently is that without the static modifier, it caused a
few warnings about not being forward declared:

I don't think it should be that much of a hassle, therefore, to
convince Junio, if we provide a patch that also squelches such
warnings. That said, we want to tread lightly. Git doesn't provide an
API, and if we start requesting changes in the name of "api
interoperability", or what have you, the git mailing list is going to
tell us to switch to libgit2 and rework a bunch of things. And while
that might make sense somewhere somehow at some point, it's part of a
separate debate I really do not want to have right now (and if you're
thinking about replying to this thread commenting on this sentence and
mentioning something about libgit2 PLEASE DO NOT -- it's for a
separate ML thread). So let's use some tact when approaching Junio
about this.

> without those methods we'll need to filter Git's graph output to convert
> ANSI colour escape sequences into HTML.

Right. Possible, but ugly.

More information about the CGit mailing list