[PATCH 3/6] Update git to v1.7.7.7

Jason A. Donenfeld Jason at zx2c4.com
Sat Mar 2 16:19:32 CET 2013

On Sat, Mar 2, 2013 at 7:32 AM, John Keeping <john at keeping.me.uk> wrote:
> This release changes the archive interface so that we now need to pass
> argv into write_archive().

It's a bit of a bummer having to do it this way -- I rather liked
struct archiver_args. Such is life.

> -       args.time = commit->date;

Do we loose something significant by not being able to provide the
date like this, or do the new args take care of this automatically
when parsing the hex?

Also, can we axe the commit lookup code, now that that pointer isn't used?

 	struct commit *commit;
 	commit = lookup_commit_reference(sha1);
 	if(!commit) {
 		cgit_print_error(fmt("Not a commit reference: %s", hex));
 		return 1;

Or are we unable to handle errors later on, and so it's best to
validate here? At the very least, we don't need the commit pointer
hanging around any longer.

More information about the CGit mailing list