[PATCH] ui-snapshot.c: Terminate cgit_snapshot_formats[] properly

Dan McGee dpmcgee at gmail.com
Sun Mar 3 23:16:35 CET 2013


On Sun, Mar 3, 2013 at 4:09 PM, Lukas Fleischer <cgit at cryptocrack.de> wrote:
> Explicitly set the suffix field of the terminating format entry to 0.
> This fixes a GCC warning seen with "-Wmissing-field-initializers".
>
> Signed-off-by: Lukas Fleischer <cgit at cryptocrack.de>
> ---
>  ui-snapshot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui-snapshot.c b/ui-snapshot.c
> index 47432bd..e740645 100644
> --- a/ui-snapshot.c
> +++ b/ui-snapshot.c
> @@ -48,7 +48,7 @@ const struct cgit_snapshot_format cgit_snapshot_formats[] = {
>         { ".tar.bz2", "application/x-bzip2", write_tar_bzip2_archive, 0x04 },
>         { ".tar", "application/x-tar", write_tar_archive, 0x08 },
>         { ".tar.xz", "application/x-xz", write_tar_xz_archive, 0x10 },
> -       {}
> +       { 0 }
Why 0 and not NULL here, as is convention for strings?

>  };
>
>  static const struct cgit_snapshot_format *get_format(const char *filename)
> --
> 1.8.2.rc0.247.g811e0c0
>
>
> _______________________________________________
> cgit mailing list
> cgit at hjemli.net
> http://hjemli.net/mailman/listinfo/cgit




More information about the CGit mailing list