[PATCH v3 3/4] cgit.mk: don't rebuild everything if CGIT_VERSION changes

René Neumann lists at necoro.eu
Thu Mar 7 09:03:11 CET 2013


> +# Only cgit.c reference CGIT_VERSION so we only rebuild its objects when the
> +# version changes.
> +CGIT_VERSION_OBJS := $(addprefix $(CGIT_PREFIX),cgit.o)
> +$(CGIT_VERSION_OBJS): $(CGIT_PREFIX)VERSION
> +$(CGIT_VERSION_OBJS): EXTRA_CPPFLAGS = \
> +	-DCGIT_VERSION='"$(CGIT_VERSION)"'

Is the small gain (not rebuilding a couple of small C-files) worth this
hassle? Because it sounds a bit like a maintenance nightmare: One more
place to remember to put a file.

If cgit were some template-C++-monster, this might be useful, but cgit
is not...

- René





More information about the CGit mailing list