[PATCH 2/5] Fix about-formatting.sh

Martin Erik Werner martinerikwerner at gmail.com
Tue Oct 8 16:06:45 CEST 2013


> dash failed to parse the script.
>
> Signed-off-by: Přemysl Janouch <p.janouch at gmail.com>
> ---
>  filters/about-formatting.sh |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/filters/about-formatting.sh b/filters/about-formatting.sh
> index 313a4e6..892fbeb 100755
> --- a/filters/about-formatting.sh
> +++ b/filters/about-formatting.sh
> @@ -18,7 +18,7 @@
>  # CGIT_REPO_CLONE_URL  ( = repo.clone-url setting )
>  
>  cd "$(dirname $0)/html-converters/"
> -case "$(tr '[:upper:]' '[:lower:]' <<<"$1")" in
> +case "$(printf '%s' "$1" | tr '[:upper:]' '[:lower:]')" in
>  	*.md|*.mkd) exec ./md2html; ;;
>  	*.rst) exec ./rst2html; ;;
>  	*.[1-9]) exec ./man2html; ;;
> -- 
> 1.7.10.4

I'd like to second this patch, I was somewhat pulling my hair trying to figure
out why it was treating html as txt until I noticed that it was simply down to
a bashism in an sh script.

--
Martin Erik Werner <martinerikwerner at gmail.com>


More information about the CGit mailing list