[PATCH] diffstat: do not rely on uninitialized data

Jason A. Donenfeld Jason at zx2c4.com
Thu Feb 20 19:50:04 CET 2014

Right now if you visit:
you'll see that if you reload the page a few times, a bunch of times the
diffstat comes out with no lines being shown or changed. I'm not
currently sure what the cause of this is, but I suspect it might have to
do with this uninitialized data.

Signed-off-by: Jason A. Donenfeld <Jason at zx2c4.com>
 shared.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/shared.c b/shared.c
index 7e88bbd..8ed14c0 100644
--- a/shared.c
+++ b/shared.c
@@ -368,6 +368,7 @@ void cgit_diff_tree(const unsigned char *old_sha1,
 	struct diff_options opt;
 	struct pathspec_item item;
+	memset(&item, 0, sizeof(item));
 	opt.output_format = DIFF_FORMAT_CALLBACK;
 	opt.detect_rename = 1;

More information about the CGit mailing list