[PATCH 1/1] print download link for reference string length == 1

Lukas Fleischer cgit at cryptocrack.de
Thu Feb 20 21:15:17 CET 2014

On Thu, 20 Feb 2014 at 20:58:53, Christian Hesse wrote:
> Christian Hesse <mail at eworm.de> on Thu, 2014/02/20 20:48:
> > I have a number of repositories that start tagging with just '1' and
> > count up. Actually references with sting length of one are skipped, this
> > patch changes that.
> Wondering if there was a good reason to use a minimum string length of two...
> Can my patch break anything? As far as I can tell is works without problems
> for me.

I can only guess because this code was added when the function was
introduced in commit 65962685 (ui-refs.c: show download links for all
tags referring to commit objects, 2008-12-01). I think it is related to
the code below accessing ref[1], though. I don't see how anything could
go wrong when the string length is 1 since isdigit('\0') should return
0 in that case. +1 from me.

> -- 
> main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
> "CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
> putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
> _______________________________________________
> CGit mailing list
> CGit at lists.zx2c4.com
> http://lists.zx2c4.com/mailman/listinfo/cgit

More information about the CGit mailing list