[PATCH 1/1] enable cgit to show gravatar for author, committer and tagger
Jason A. Donenfeld
Jason at zx2c4.com
Wed Jan 8 17:00:50 CET 2014
Sorry for the extended nitpicks....
On Wed, Jan 8, 2014 at 4:23 PM, Christian Hesse <mail at eworm.de> wrote:
> +char *cgit_get_gravatar(const char *email)
> + /* duplicate to lower and skip brackets! */
> + lower = strdup(email + 1);
> + lower[strlen(lower) - 1] = '\0';
Can email ever be passed in with no length at all? Or without
brackets? It's not immediately clear to me from looking briefly at
parse_user in parsing.c.
More information about the CGit