[PATCH 2/2] README: Update dependencies
cgit at cryptocrack.de
Thu Jan 9 20:26:24 CET 2014
On Thu, 09 Jan 2014 at 19:01:42, John Keeping wrote:
> On Thu, Jan 09, 2014 at 04:13:08PM +0100, Jason A. Donenfeld wrote:
> > On Thu, Jan 9, 2014 at 8:30 AM, Lukas Fleischer <cgit at cryptocrack.de> wrote:
> > > We depend on Git in the test suite. Maybe this should be changed to use
> > > the binary from the Git submodule instead?
> > I think we discussed the possibility of this a while ago with John.
> > This would make most sense to me, though we are using git's test
> > harness, and I'd like to avoid making invasive changes in that, if
> > possible.
> We do already build the Git tools when building the test target (as
> opposed to just libgit.a when building the cgit binary), but I can't
> remember why we do this...
> It's probably simplest just to further tweak $PATH in tests/setup.sh so
> it also prepends "$(pwd)/../../git/bin-wrappers". That should cause us
> to use the Git tools from the submodule without needing to do anything
That sounds like a good idea to me. Do you want to prepare a patch?
> > In either case, I wouldn't consider the test case a hard dependency,
> > and so I'm okay with removing git from the dep list. Or changing it to
> > "Git 1.8.5 (included)" or similar.
More information about the CGit