[PATCH] Disallow downloading disabled snapshot formats

Lukas Fleischer cgit at cryptocrack.de
Fri Jan 10 18:14:50 CET 2014

On Fri, 10 Jan 2014 at 17:11:46, Jason A. Donenfeld wrote:
> On Fri, Jan 10, 2014 at 3:38 PM, Lukas Fleischer <cgit at cryptocrack.de> wrote:
> > We did only display enabled snapshot formats but we did not prevent from
> > downloading disabled formats when requested. Fix this by adding an
> > appropriate check.
> Previously:
> http://lists.zx2c4.com/pipermail/cgit/2012-June/000641.html
> http://lists.zx2c4.com/pipermail/cgit/2012-October/000792.html

I was also thinking of server load. If we want to leave it as-is, we
should fix the documentation which currently says:

    	A mask of allowed snapshot-formats for this repo, restricted by
    	the "snapshots" global setting. Default value: <snapshots>.

There should at least be a note stating that "allowed" only means
"linked" here.

More information about the CGit mailing list