[PATCH v2] filters: Improved syntax-highlighting.py

Jason A. Donenfeld Jason at zx2c4.com
Mon Jan 13 15:21:32 CET 2014

Thanks for all your hard work on this. Sorry for the extended back and
forth. More comments, alas alas, below.

On Mon, Jan 13, 2014 at 12:02 PM, Stefan Tatschner <stefan at sevenbyte.org> wrote:
> - Using inline CSS instead of this sys.stdout.print() hack.

Please don't do this. Inline CSS makes for much bigger files, and
there's nothing in the HTML5 spec that forbids us from putting <style>
tags there in the first place.

> - Using trac theme for pygments (it is very clean and not intrusive like the
>   default or pastie theme).

This is probably best as a separate commit, since some folks might complain.

> - I had to fix cgit.css according to a alignment issue with the line-numbers
>   table.

This is this issue, right?

Why does changing the line-height to 125% fix it exactly?

More information about the CGit mailing list