[PATCH] ui-patch: Flush stdout after outputting data

Konstantin Ryabitsev mricon at kernel.org
Wed Jun 11 22:28:26 CEST 2014


On 11/06/14 04:01 PM, John Keeping wrote:
> Since the "html" functions use raw write(2) to STDIO_FILENO, we don't
> notice problems with most pages, but raw patches write using printf(3).
> This is fine if we're outputting straight to stdout since the buffers
> are flushed on exit, but we close the cache output before this, so the
> cached output ends up being truncated.
> 
> Make sure the buffers are flushed when we finish outputting a patch so
> that we avoid this.
> 
> No other UIs use printf(3) so we do not need to worry about them.

Confirming fix -- in production at kernel.org.
Thanks a ton for the lightning-speed turnaround.

Best,
-- 
Konstantin Ryabitsev
Senior Systems Administrator
Linux Foundation Collab Projects
Montréal, Québec

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 538 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20140611/cb95e004/attachment.asc>


More information about the CGit mailing list