[PATCH 1/1] git: update for git 2.0

[Christian Hesse]

Lukas Fleischer <cgit at cryptocrack.de> on Sun, 2014/05/04 22:03:
> On Sun, 04 May 2014 at 21:31:39, Christian Hesse wrote:
> > prefixcmp() and suffixcmp() have been remove, functionality is now
> > provided by starts_with() and ends_with(). Retrurn values have been
> > changed, so instead of just renaming we have to fix logic.
> > Everything else looks just fine.
> > ---
> >  Makefile      |  4 ++--
> >  cgit.c        | 26 +++++++++++++-------------
> >  git           |  2 +-
> >  parsing.c     | 12 ++++++------
> >  scan-tree.c   | 10 +++++++---
> >  ui-clone.c    |  2 +-
> >  ui-log.c      |  8 ++++----
> >  ui-refs.c     |  6 +++---
> >  ui-repolist.c |  2 +-
> >  ui-shared.c   |  2 +-
> >  ui-snapshot.c |  4 ++--
> >  ui-summary.c  |  2 +-
> >  12 files changed, 42 insertions(+), 38 deletions(-)
> > 
> > [...]
> > -       else if (!prefixcmp(name, "module-link.")) {
> > +       else if (starts_with(name, "module-link.")) {
> >                 item = string_list_append(&repo->submodules, xstrdup(name
> > + 12));
> 
> My original intention was to replace most of these with skip_prefix()
> (well, I actually wanted to wait for strip_prefix() to replace
> skip_prefix() but that didn't make it into Git 2.0). It would be great
> to see most of the starts_with() invocations (followed by hardcoded
> lengths) replaced by skip_prefix() but if you don't want to do it, I
> guess this change is okay for now.

I would suggest going the simplest transition first, then make enhancements
in a later commit. Replying with a patch for final git v2.0.0.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"C7?Bj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20140529/5afbc0ef/attachment.asc>