[PATCH 0/3] Blame UI

John Keeping john at keeping.me.uk
Wed Aug 12 17:02:58 CEST 2015


On Wed, Aug 12, 2015 at 03:44:19PM +0200, Jason A. Donenfeld wrote:
> On Wed, Aug 12, 2015 at 3:03 PM, John Keeping <john at keeping.me.uk> wrote:
> > This is an attempt at adding "blame" support to CGit.  Because git.git
> > doesn't include the blame implementation in libgit.a, I decided to
> > simply invoke git-blame(1) and parse its porcelain output.
> 
> Could you possibly just do:
> 
> #include "git/builtin/blame.c"
> 
> And then call the static functions?

I was trying to stay to a well defined interface.  It looks like we'd
have to copy reasonable chunks of cmd_blame() and emit_other() in order
to drive the static functions.

I'll give it a go and see what it looks like, but I expect it to result
in more pain during future maintenance than using a separate process.


More information about the CGit mailing list