[PATCH v2 00/22] HTTP status code improvements

Nicolas Dely nicolas.dely at technicolor.com
Fri Aug 14 14:17:30 CEST 2015


Hi,

I really appreciate cgit developers who have spent time working on our 
issue[0] ;-)

Please let me a recommended cgit version/sha1 so that I can send you any 
feedback.

Regards,

Nicolas

[0]http://lists.zx2c4.com/pipermail/cgit/2015-March/002464.html


On 08/14/2015 01:47 PM, John Keeping wrote:
> Changes since v1 (starts at [0]):
> - Rebased on the latest master
> - Following Christian's patch [1], a new patch changes ui-patch.c to use
>    cgit_print_error_page() and other new patches fix similar issues in
>    ui-blob.c and ui-snapshot.c
> - The last patch is new, and uses "cache-dynamic-ttl" for error pages;
>    I'm not 100% sure about that, but it's better than the current
>    behaviour if someone tries to access a page by SHA1 before the object
>    has been pushed to the repository CGit is displaying
>
> [0] http://article.gmane.org/gmane.comp.version-control.cgit/2451
> [1] http://article.gmane.org/gmane.comp.version-control.cgit/2589
>
> John Keeping (22):
>    ui-shared: add cgit_print_error_page() function
>    cgit: use cgit_print_error_page() where appropriate
>    clone: use cgit_print_error_page() instead of html_status()
>    plain: use cgit_print_error_page() instead of html_status()
>    snapshot: use cgit_print_error_page() instead of html_status()
>    blob: use cgit_print_error_page() to add HTTP headers
>    patch: use cgit_print_error_page() for HTTP status codes
>    snapshot: use cgit_print_error_page() for HTTP status codes
>    snapshot: don't reimplement cgit_print_error_page()
>    html: remove html_status()
>    ui-shared: add cgit_print_layout_{start,end}()
>    about: move layout into page functions
>    commit: move layout into page function
>    diff: move layout to page function
>    log: move layout into page function
>    refs: move layout to page function
>    stats: move layout into page function
>    summary: move layout into page function
>    tag: move layout into page function
>    tree: move layout into page function
>    cmd: remove "want_layout" field
>    ui-shared: cache errors for "dynamic TTL"
>
>   cgit.c        | 36 +++++++-----------------------------
>   cmd.c         | 48 ++++++++++++++++++++++++------------------------
>   cmd.h         |  1 -
>   html.c        |  7 -------
>   html.h        |  1 -
>   ui-blob.c     | 12 ++++++++----
>   ui-clone.c    | 10 +++++-----
>   ui-commit.c   |  8 ++++++--
>   ui-diff.c     | 19 ++++++++++++++-----
>   ui-log.c      |  5 ++++-
>   ui-patch.c    | 16 ++++++++--------
>   ui-plain.c    | 10 +++++-----
>   ui-refs.c     |  3 ++-
>   ui-repolist.c |  5 ++++-
>   ui-shared.c   | 27 +++++++++++++++++++++++++++
>   ui-shared.h   |  5 +++++
>   ui-snapshot.c | 29 +++++++++--------------------
>   ui-stats.c    |  8 ++++++--
>   ui-summary.c  | 10 ++++++++--
>   ui-tag.c      | 13 ++++++++++---
>   ui-tree.c     | 23 ++++++++++++++++++-----
>   21 files changed, 170 insertions(+), 126 deletions(-)
>



More information about the CGit mailing list