[PATCH v2] ui-clone.c: Fix path check
Lukas Fleischer
cgit at cryptocrack.de
Mon Feb 9 07:25:00 CET 2015
The starts_with() check was broken in two ways: For one thing, the
parameters were passed in the wrong order, for another thing,
starts_with() returns 1 if the string starts with the prefix (not 0).
Note that this bug existed since commit 02a545e (Add support for cloning
over http, 2008-08-06) but only pops in in corner cases.
Signed-off-by: Lukas Fleischer <cgit at cryptocrack.de>
---
Using skip_prefix() might be even better here :)
ui-clone.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui-clone.c b/ui-clone.c
index 50569d6..1e6238d 100644
--- a/ui-clone.c
+++ b/ui-clone.c
@@ -63,8 +63,8 @@ static void send_file(char *path)
}
ctx.page.mimetype = "application/octet-stream";
ctx.page.filename = path;
- if (!starts_with(ctx.repo->path, path))
- ctx.page.filename += strlen(ctx.repo->path) + 1;
+ skip_prefix(path, ctx.repo->path, &ctx.page.filename);
+ skip_prefix(ctx.page.filename, "/", &ctx.page.filename);
cgit_print_http_headers();
html_include(path);
}
--
2.3.0
More information about the CGit
mailing list