[PATCH 00/13] Fixes for problems detected by Sparse
John Keeping
john at keeping.me.uk
Sun Mar 8 17:32:14 CET 2015
Sparse[0] detects several potential problems in CGit, which are all
fixed by this set of patches. Most of these are style issues that are
correct either way (using integer zero as a NULL pointer), but I think
there is value in keeping the build clean of Sparse warnings.
[0] https://sparse.wiki.kernel.org/index.php/Main_Page
John Keeping (13):
Makefile: add a target to run CGit through sparse
Avoid non-ANSI function declarations
Avoid signed bitfields
scan-tree: make some variables 'static'
shared: make some variables 'static'
ui-log: make some variables 'static'
ui-repolist: make sortcolumn definitions 'static const'
ui-shared: make cgit_doctype 'static'
ui-stats: make cgit_period definitions 'static const'
ui-shared: avoid initializing static variable to zero
ui-shared: don't use an integer as a NULL pointer
cache: don't use an integer as a NULL pointer
html: avoid using a plain integer as a NULL pointer
Makefile | 3 +++
cache.c | 2 +-
cgit.c | 2 +-
cgit.mk | 9 ++++++++-
filter.c | 2 +-
html.c | 54 ++++++++++++++++++++++++++++++++----------------------
scan-tree.c | 4 ++--
shared.c | 4 ++--
ui-blob.c | 4 ++--
ui-diff.c | 4 ++--
ui-log.c | 2 +-
ui-refs.c | 4 ++--
ui-repolist.c | 10 +++++-----
ui-shared.c | 18 +++++++++---------
ui-ssdiff.c | 16 ++++++++--------
ui-stats.c | 14 +++++++-------
ui-stats.h | 2 +-
ui-summary.c | 2 +-
ui-tree.c | 4 ++--
19 files changed, 90 insertions(+), 70 deletions(-)
--
2.3.1.308.g754cd77
More information about the CGit
mailing list