[PATCH] ui-commit: display commit notes as 'raw'
john at keeping.me.uk
Sat Mar 21 14:19:38 CET 2015
On Sat, Mar 21, 2015 at 02:11:51PM +0100, Stefan Naewe wrote:
> On Fri, Mar 20, 2015 at 10:29 PM, John Keeping <john at keeping.me.uk> wrote:
> > On Fri, Mar 20, 2015 at 05:39:53PM +0100, Stefan Naewe wrote:
> >> When the git function format_display_notes() is called
> >> with a value != 0 as the last argument ('raw') the notes text
> >> gets displayed w/o an additional 'Notes:' header. This seems
> >> to be better suited for our needs since we're already displaying
> >> a similar header.
> > What happens when there are multiple display notes refs? It seems that
> > without "raw", format_note() puts the name of the ref in the header it
> > prints (if it's not the default notes ref).
> That's true for 'git show --notes=...' for example.
> But how would you specify the name of the notes ref in cgit ?
git config --add notes.displayRef ...
> > It's possible that the correct answer is that we don't care about that
> > case, but it is potentially a regression for people who want to display
> > multiple notes.
> Attached are two screenshots of commit notes added with 'git notes
> add..' for the first line and
> 'git notes append...' for the second line. That particular commit also
> has another note
> attached in the 'refs/notes/todo' namespace.
> My opinion about this topic: I really like the way cgit displays the
> commit notes but not the
> double "Notes" header line.
More information about the CGit