[PATCH 6/8] cmd: fix resource leak: free allocation from cgit_currenturl and fmtalloc

Christian Hesse list at eworm.de
Fri Oct 9 13:15:49 CEST 2015


From: Christian Hesse <mail at eworm.de>

Signed-off-by: Christian Hesse <mail at eworm.de>
---
 cmd.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/cmd.c b/cmd.c
index c991092..3093c62 100644
--- a/cmd.c
+++ b/cmd.c
@@ -41,9 +41,13 @@ static void about_fn(void)
 	if (ctx.repo) {
 		if (!ctx.qry.path &&
 		    ctx.qry.url[strlen(ctx.qry.url) - 1] != '/' &&
-		    ctx.env.path_info[strlen(ctx.env.path_info) - 1] != '/')
-			cgit_redirect(fmtalloc("%s/", cgit_currenturl()), true);
-		else
+		    ctx.env.path_info[strlen(ctx.env.path_info) - 1] != '/') {
+			char *currenturl = cgit_currenturl();
+			char *redirect = fmtalloc("%s/", currenturl);
+			cgit_redirect(redirect, true);
+			free(currenturl);
+			free(redirect);
+		} else
 			cgit_print_repo_readme(ctx.qry.path);
 	} else
 		cgit_print_site_readme();
-- 
2.6.1



More information about the CGit mailing list