[PATCH 3/6] ui-atom: fix resource leak: free allocation from cgit_repourl

Christian Hesse list at eworm.de
Sat Oct 10 16:56:25 CEST 2015


From: Christian Hesse <mail at eworm.de>

Coverity-id: 13947
Signed-off-by: Christian Hesse <mail at eworm.de>
---
 ui-atom.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ui-atom.c b/ui-atom.c
index e2b39ee..d7138fb 100644
--- a/ui-atom.c
+++ b/ui-atom.c
@@ -125,11 +125,13 @@ void cgit_print_atom(char *tip, char *path, int max_count)
 	html_txt(ctx.repo->desc);
 	html("</subtitle>\n");
 	if (host) {
+		char *repourl = cgit_repourl(ctx.repo->url);
 		html("<link rel='alternate' type='text/html' href='");
 		html(cgit_httpscheme());
 		html_attr(host);
-		html_attr(cgit_repourl(ctx.repo->url));
+		html_attr(repourl);
 		html("'/>\n");
+		free(repourl);
 	}
 	while ((commit = get_revision(&rev)) != NULL) {
 		add_entry(commit, host);
-- 
2.6.1



More information about the CGit mailing list